feat!: Add support for reserved_internal_range in secondary IP ranges #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bharathkkb
reviewed
Oct 17, 2025
| ip_cidr_range = secondary_ip_range.value.ip_cidr_range | ||
| range_name = secondary_ip_range.value.range_name | ||
| ip_cidr_range = secondary_ip_range.value.ip_cidr_range | ||
| reserved_internal_range = secondary_ip_range.value.reserved_internal_range |
There was a problem hiding this comment.
Lets bump the min provider version to 6.0 when support for this field was added to the provider (for this and beta module)
https://github.com/hashicorp/terraform-provider-google/blob/main/CHANGELOG.md#600-august-26-2024
examples/secondary_ranges/main.tf
Outdated
| # Example of using reserved_internal_range instead of ip_cidr_range | ||
| # { | ||
| # range_name = "${local.subnet_03}-02" | ||
| # reserved_internal_range = "networkconnectivity.googleapis.com/projects/my-project/locations/global/internalRanges/my-range" |
There was a problem hiding this comment.
Could we create this resource as part of the example?
bharathkkb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the reserved_internal_range field in subnet secondary ranges